feat: upload add download icon #18664

crazyair · 2019-09-04T08:41:49Z

🤔 This is a ...

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language	Changelog
🇺🇸 English	upload add download,remove icon , remove close icon
🇨🇳 Chinese	upload 添加下载、删除图标，删除 close 图标

☑️ Self Check before Merge

Doc is updated/provided or not needed
Demo is updated/provided or not needed
TypeScript definition is updated/provided or not needed
Changelog is provided or not needed

tests-checker

Could you please add tests to make sure this change works as expected?

netlify · 2019-09-04T08:41:59Z

Deploy preview for ant-design ready!

Built with commit eaf7201

https://deploy-preview-18664--ant-design.netlify.com

buildsize · 2019-09-04T08:45:16Z

File name	Previous Size	New Size	Change
package-lock.json	851.16 KB	848.89 KB	-2.27 KB (0%)

afc163 · 2019-09-04T10:29:17Z

超长文件名的样式截断没有兼容好。

原本的：

现在的：

afc163 · 2019-09-04T10:29:48Z

changelog 里漏掉了删除图标❌的更新。

components/upload/index.en-US.md

components/upload/index.zh-CN.md

crazyair · 2019-09-04T11:13:24Z

@afc163 1、超长文件名 2、log 已改

dengfuping · 2019-09-05T02:02:41Z

这什么错误啊

@qq645381995 这个不影响测试，先忽略就好。但现在 demo 测试是挂了的，需要修复下。

crazyair · 2019-09-05T02:21:51Z

好的

crazyair · 2019-09-06T02:51:16Z

超长文件名的样式截断没有兼容好。

原本的：

现在的：

改了

docs/spec/work-with-us.zh-CN.md

components/config-provider/__tests__/__snapshots__/components.test.js.snap

components/upload/UploadList.tsx

afc163 · 2019-09-11T08:35:42Z

默认情况下有点浪费空间，可以hover上去真正出现 icon 了才改 padding。

crazyair · 2019-09-11T08:40:20Z

默认情况下有点浪费空间，可以hover上去真正出现 icon 了才改 padding。

添加完了，全部判断了显示的 icon 的数量去计算 padding-right

crazyair · 2019-09-11T11:43:56Z

@afc163 这是什么代码又报错了？

mansion-sun · 2020-01-10T07:34:54Z

onDownload里面需要自定义下载方法吗？目前的下载按钮打开csv文件连接时进入新标签页，但是不触发下载

yoyo837 · 2020-01-10T07:41:30Z

@sunxia628 那是因为你的浏览器支持打开csv文件，如果不支持就会触发下载。你可以试试右键链接，另存为。。。

mansion-sun · 2020-01-10T08:06:39Z

没有，打开后是空页面，也并没有访问到文件，另存为存储的是当前页面的html

yoyo837 · 2020-01-10T08:11:49Z

那你这不是链接的那种。

mansion-sun · 2020-01-10T08:17:05Z

我尝试了按钮这种是可以下载的，
<a href="https://www.w3school.com.cn/i/w3school_logo_white.csv" download="w3school_logo_white.csv">
同样的链接点击组件的下载按钮就打开了空页面!

mansion-sun · 2020-01-16T05:47:44Z

showUploadList：Boolean or { showPreviewIcon?: boolean, showRemoveIcon?: boolean, showDownloadIcon?: boolean }可以指定是否显示按钮可以传reactDom就能够实现定制化开发了，不知道这个功能是自己没发现，还是使用错误，希望可以支持！
@yoyo837
@afc163
路径替换为绝对路径就可以了，自动拼接的路径携带路由，这个可能还是项目问题，但是Upload组件可以支持自定义下载按钮可以不必钻这坑

afc163 · 2020-02-20T14:30:57Z

components/upload/UploadList.tsx

@@ -16,6 +16,7 @@ export default class UploadList extends React.Component<UploadListProps, any> {
      showInfo: false,
    },
    showRemoveIcon: true,
+    showDownloadIcon: true,


感觉应该改成默认为 false，咨询去掉的反馈比较多。@crazyair

嗯，帮忙改成 false 把，这个需要后端支持，一般场景用不到。

crazyair · 2020-02-20T14:44:08Z

onDownload里面需要自定义下载方法吗？目前的下载按钮打开csv文件连接时进入新标签页，但是不触发下载

对，默认的行为就是打开连接，浏览器支持的格式会渲染出来，不支持的会触发下载。

feat: upload add download icon

929c56e

pr-triage bot added the PR: unreviewed label Sep 4, 2019

tests-checker bot suggested changes Sep 4, 2019

View reviewed changes

pr-triage bot added PR: reviewed-changes-requested and removed PR: unreviewed labels Sep 4, 2019

crazyair mentioned this pull request Sep 4, 2019

feat: Upload add download #18661

Closed

14 tasks

dengfuping reviewed Sep 4, 2019

View reviewed changes

components/upload/index.en-US.md Outdated Show resolved Hide resolved

components/upload/index.zh-CN.md Outdated Show resolved Hide resolved

feat: clear up

8bf444b

pr-triage bot added PR: unreviewed and removed PR: reviewed-changes-requested labels Sep 4, 2019

feat: log

3f0c684

qq645381995 and others added 3 commits September 4, 2019 19:28

Merge branch 'feature' into upload-add-download

f56cc33

empty

cc13047

feat: 理解错误

552fc67

crazyair added 2 commits September 5, 2019 14:34

Merge remote-tracking branch 'upstream/feature' into upload-add-download

e099d19

feat: test

950a319

crazyair requested a review from dengfuping September 6, 2019 02:49

crazyair added 2 commits September 7, 2019 11:25

chore: merge feature

a64bc2a

test

4104c88

afc163 reviewed Sep 7, 2019

View reviewed changes

docs/spec/work-with-us.zh-CN.md Outdated Show resolved Hide resolved

afc163 reviewed Sep 7, 2019

View reviewed changes

components/config-provider/__tests__/__snapshots__/components.test.js.snap Outdated Show resolved Hide resolved

feat: clean up

accd786

afc163 reviewed Sep 10, 2019

View reviewed changes

components/upload/UploadList.tsx Outdated Show resolved Hide resolved

fix: test

04d9f59

crazyair requested a review from afc163 September 10, 2019 03:22

afc163 reviewed Sep 10, 2019

View reviewed changes

components/upload/UploadList.tsx Outdated Show resolved Hide resolved

fix: [] key

e02dbdc

crazyair requested a review from afc163 September 10, 2019 03:44

fix: hover css

a2a4d85

fix: test

eaf7201

afc163 approved these changes Sep 11, 2019

View reviewed changes

pr-triage bot added PR: reviewed-approved and removed PR: unreviewed labels Sep 11, 2019

afc163 merged commit f659d23 into ant-design:feature Sep 11, 2019

pr-triage bot added PR: merged and removed PR: reviewed-approved labels Sep 11, 2019

crazyair deleted the upload-add-download branch October 17, 2019 05:02

snyk-bot mentioned this pull request Nov 19, 2019

[Snyk] Upgrade antd from 3.23.6 to 3.25.1 ndom91/newtelco-next-maintenance-mgmt#9

Closed

afc163 reviewed Feb 20, 2020

View reviewed changes

afc163 mentioned this pull request Feb 20, 2020

fix: Upload should not showing download icon defaultly #21496

Merged

14 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: upload add download icon #18664

feat: upload add download icon #18664

crazyair commented Sep 4, 2019 •

edited

tests-checker bot left a comment

netlify bot commented Sep 4, 2019 •

edited

buildsize bot commented Sep 4, 2019 •

edited

afc163 commented Sep 4, 2019

afc163 commented Sep 4, 2019

crazyair commented Sep 4, 2019

dengfuping commented Sep 5, 2019

crazyair commented Sep 5, 2019

crazyair commented Sep 6, 2019

afc163 commented Sep 11, 2019

crazyair commented Sep 11, 2019 •

edited

crazyair commented Sep 11, 2019

mansion-sun commented Jan 10, 2020

yoyo837 commented Jan 10, 2020

mansion-sun commented Jan 10, 2020 •

edited

yoyo837 commented Jan 10, 2020

mansion-sun commented Jan 10, 2020 •

edited

mansion-sun commented Jan 16, 2020 •

edited

afc163 Feb 20, 2020 •

edited

crazyair Feb 20, 2020

crazyair commented Feb 20, 2020

feat: upload add download icon #18664

feat: upload add download icon #18664

Conversation

crazyair commented Sep 4, 2019 • edited

🤔 This is a ...

🔗 Related issue link

💡 Background and solution

📝 Changelog

☑️ Self Check before Merge

tests-checker bot left a comment

Choose a reason for hiding this comment

netlify bot commented Sep 4, 2019 • edited

buildsize bot commented Sep 4, 2019 • edited

afc163 commented Sep 4, 2019

afc163 commented Sep 4, 2019

crazyair commented Sep 4, 2019

dengfuping commented Sep 5, 2019

crazyair commented Sep 5, 2019

crazyair commented Sep 6, 2019

afc163 commented Sep 11, 2019

crazyair commented Sep 11, 2019 • edited

crazyair commented Sep 11, 2019

mansion-sun commented Jan 10, 2020

yoyo837 commented Jan 10, 2020

mansion-sun commented Jan 10, 2020 • edited

yoyo837 commented Jan 10, 2020

mansion-sun commented Jan 10, 2020 • edited

mansion-sun commented Jan 16, 2020 • edited

afc163 Feb 20, 2020 • edited

Choose a reason for hiding this comment

crazyair Feb 20, 2020

Choose a reason for hiding this comment

crazyair commented Feb 20, 2020

crazyair commented Sep 4, 2019 •

edited

netlify bot commented Sep 4, 2019 •

edited

buildsize bot commented Sep 4, 2019 •

edited

crazyair commented Sep 11, 2019 •

edited

mansion-sun commented Jan 10, 2020 •

edited

mansion-sun commented Jan 10, 2020 •

edited

mansion-sun commented Jan 16, 2020 •

edited

afc163 Feb 20, 2020 •

edited